php - max winning and losing streaks (code optimization) -


i made code calculating max winning & losing streaks on array of values. can head around doing in 1 foreach loop. i'm using 2 loops follow :

  public function calculatestreaks()   {     $max_win_streak = 0;     $_win_streak = 0;     $max_loss_streak = 0;     $_loss_streak = 0;      foreach($this->all_trades_pnl $value){       if($value >= 0) {         $_win_streak++;         if($_win_streak > $max_win_streak){           $max_win_streak = $_win_streak;         }       }       else {         $_win_streak = 0;       }     }     foreach($this->all_trades_pnl $value){       if($value < 0) {         $_loss_streak++;         if($_loss_streak > $max_loss_streak) {           $max_loss_streak = $_loss_streak;         }       }       else {         $_loss_streak = 0;       }     }     return array('win_streak' => $max_win_streak, 'loss_streak' => $max_loss_streak);    }

it works seems far optimized, ideas code better ? lot in advance, regards, john

since both loop equal think can mix them toghter , assign variables @ once follow

public function calculatestreaks() {     $max_win_streak = 0;     $_win_streak = 0;     $max_loss_streak = 0;     $_loss_streak = 0;      foreach($this->all_trades_pnl $value){       if($value >= 0) {         $_win_streak++;         if($_win_streak > $max_win_streak){           $max_win_streak = $_win_streak;         }         $_loss_streak = 0;       }       else if($value < 0) {         $_loss_streak++;         if($_loss_streak > $max_loss_streak) {           $max_loss_streak = $_loss_streak;         }         $_win_streak = 0;       }     }     return array('win_streak' => $max_win_streak, 'loss_streak' => $max_loss_streak); }

Comments

Post a Comment

Popular posts from this blog

SPSS keyboard combination alters encoding -

my question not have programming practical issue on spss. accident keyword combination cannot remember because did not intend press changed encoding in spss , text in data in different language english shown small boxes. nevertheless, when kind of analysis performed different language text shown in output. does know reason? tried change encoding did not produce result. first, @ edit > options , see whether setting unicode or locale. might fix it. if have text in multiple languages, want unicode. otherwise, may have specific locale set wrong. can change set locale, need know locale want use.
Read more

Add new record to the table by click on the button in Microsoft Access -

in ms access form want implement separate button, adds new record table. in order added button , attached button event: private sub btnaddrec_click() refresh codecontextobject on error resume next docmd.gotorecord , , acnewrec if err.number <> 0 btnaddrec.enabled = false end if end end sub everything ok when open window , click btnaddrec button, problem when first of perform navigation through existed records , after click on button. got runtime error: 2105: «you can't go specified record. may @ end of recordset» . how solve issue, need have ability add new record on click on specific button, no matter, have walked or not walked through records before. thanks. i created simple form field call description (and autonumber) , created button code follows click event. filled number of records , navigated through them, clicked addnewrec button. form navigated new record without issues. able click addnewrec button directly after
Read more

CSS3 Transition to highlight new elements created in JQuery -

i want use css3 color transition apply highlight-fading color effect (yellow transparent) new elements appended markup using jquery. css #content div { background-color:transparent; -moz-transition:background-color 2s; -webkit-transition:background-color 2s; -o-transition:background-color 2s; transition:background-color 2s; } #content div.new { background-color:yellow; } html <div id="content"></div> <a id="add-element" href="#">add new element</a> js $('#add-element').click(function() { var newelement = $('<div class="new">new element</div>'); $('#content').append(newelement); newelement.removeclass('new'); }); when click link, new element created. class "new" (background color yellow) , it's appended html markup. should able remove "new" class trigger background color transition transparent (or whate
Read more