sizeof - C++ fread: unsigned char and short mixture -


i have sample code here:

    unsigned char *m_fbytes;     m_fbytes = (unsigned char*)malloc(m_ibytelen1framedecoded*sizeof(short));      int err;     err = fread(m_fbytes, sizeof(short), 960, fin);     curr_read = err;     for(int i=0;i<curr_read;i++)     {         opus_int32 s;         s=m_fbytes[2*i+1]<<8|m_fbytes[2*i];         s=((s&0xffff)^0x8000)-0x8000;         m_in[i]=s;     }      int ilen = encode(m_enc, m_in, m_ibytelen1framedecoded, m_data, m_max_payload_bytes);

i don't understand line:

err = fread(m_fbytes, sizeof(short), 960, fin);

the authors of code read bytes (aka unsigned char), pass sizeof(short).

why use "sizeof(short)"?

the code contains couple of tacit assumptions make unnecessarily fragile. way read bytes used

s=m_fbytes[2*i+1]<<8|m_fbytes[2*i]; s=((s&0xffff)^0x8000)-0x8000;

the assumptions are

  • char_bit == 8; that's pretty safe assumption nowadays, unless 1 deals exotic hardware, it's not guaranteed.

  • sizeof(short) == 2; that's true, not guaranteed either.

the way read bytes used, each adjacent pair of them make 1 unit in final result (and using 2 instead of sizeof(short) more robust, if sizeof(short) > 2, use part of read data [if sizeof(short) == 1, char_bit must @ least 16, in case stuff break in different way]).

the size parameter fread used specify how many bytes make 1 unit, no partial units read, , buffer contains err complete units.


Comments

Post a Comment

Popular posts from this blog

.htaccess - First slash is removed after domain when entering a webpage in the browser -

sometimes when hit address of webpage in browser, removes first slash after domain. examples: www.mywebsite.com/scripts/script_6.php -> trying load www.mywebsite.comscripts/script_6.php www.mywebsite.com/test.php -> trying load www.mywebsite.comtest.php after entering again, loads page. a .htaccess settings must wrong: rewritebase / errordocument 404 http://www.mywebsite.com/oops.php errordocument 401 /notallowed.php rewriteengine on # turn on rewriting engine #gzip <ifmodule mod_deflate.c> addoutputfilterbytype deflate text/text text/html text/plain text/xml text/css application/x- javascript application/javascript </ifmodule> #end gzip rewritecond %{http_host} ^mywebsite\.com rewriterule ^(.*)$ http://www.mywebsite.com$1 [r=permanent,l] directoryindex index6.php rewriterule ^termsofuse/?$ termsofuse.php [nc,l] # handle requests "adpolicy" rewriterule ^privacy-policy/?$ privacy-policy.php [nc,l] # handle requ...
Read more

Socket.connect doesn't throw exception in Android -

if put nonsense url no exception thrown , none of rest of code executed not rest of asynctask called method connects. try { socketcliente.connect(new inetsocketaddress("f", port), 2000); } catch (unknownhostexception e) { geterror("host doesn't exist"); return -1; } catch (ioexception e) { geterror("could not connect: host down"); return -1; } add catch statement. catch ( exception e ) { log.d(tag, e.getmessage(),e); toast.maketext(getapplicationcontext(), "unexpected error:" + e.getmessage(), toast.length_long).show(); } this write log , pop toast tell what's going on.
Read more

SPSS keyboard combination alters encoding -

my question not have programming practical issue on spss. accident keyword combination cannot remember because did not intend press changed encoding in spss , text in data in different language english shown small boxes. nevertheless, when kind of analysis performed different language text shown in output. does know reason? tried change encoding did not produce result. first, @ edit > options , see whether setting unicode or locale. might fix it. if have text in multiple languages, want unicode. otherwise, may have specific locale set wrong. can change set locale, need know locale want use.
Read more