php - Secure URL functions? -


my company's website got hacked, , i'm restoring website caution. company wants site possible don't have enough time re-code software's vulnerabilities away, i'm restoring after doing following:

  1. disabling input forms website. (basically, forms said action = someform.php renamed someform.php on server someform1.php nothing gets database. deal pdo , protection sql injections later).
  2. with no forms left, there's no $_post input take care of, there's still $_get. every page takes in query string, i've put check on every $_get[''] variable , made sure process when it's numeric should be. eg. if(isset($_get['page_id']) && is_numeric($_get['page_id'])) { /* */ }. hacker seemed have broken through using sql injections.
  3. with section of website (accessible company staff @ moment), i've made password protected folder. know hacker still use anonymous ftp or in using other ways, i'm hoping @ least avoid sql injections initially, thought password protected folder help. on top of existing secure login.
  4. i'm worried url. i'm not sure how secure or isn't, it's bilingual website, , way it's going (this part of code previous developer , don't understand it):

if($_server['server_name'] == 'localhost' || $_server['server_name'] == 'salman'){     $url =zeej_dir.curpagename().'?'.$_server["query_string"]; } else {     $url ='/'.curpagename().'?'.$_server["query_string"]; } $change_url = "http://".$_server['server_name'].$url;   if($_session['ln'] == 'en'){          echo '<img src="'.getsiteurl().'images/arabicicon.jpg" alt="arabic" width="15" height="15" />';         echo '<a href="'.getsiteurl().'change_session.php?page_url='.base64_encode( $change_url ).'" class="top_frametext">arabic</a>';     } else {         echo '<img src="'.getsiteurl().'images/engicon.jpg" alt="english" width="15" height="15" />';         echo '<a href="'.getsiteurl().'change_session.php?page_url='.base64_encode( $change_url ).'" class="top_frametext">english</a>';     }

and code change_session.php:

@session_start(); $page_url = isset($_request['page_url'])?$_request['page_url']:'';  if($_session['ln'] == 'en'){     $_session['ln'] ='ar'; } else {     $_session['ln'] ='en'; }  header("location: ".base64_decode($page_url));exit;

are there vulnerabilities here via url? or reasonably secured far?

one hint/note: regarding sql injection mentioned, make sure you're , everywhere using http://php.net/manual/en/pdo.prepared-statements.php

regarding changing language (in session). code seems safe since nobody inject or change something.

under line:

however, see 1 problem in url construction. uses base64_encode method make url "secure". however, can decode (since base64 encoding). long-term, may try using symetric encryption genereted key stored in user's session. way, nobody use url generated else.

anyway, changing language harmless in case. above mentioned proposal resources/operations needs secured. mean authorized person access (and not have stolen url). there are, of course, other ways how protect site. 1 practical advice.


Comments

Post a Comment

Popular posts from this blog

SPSS keyboard combination alters encoding -

my question not have programming practical issue on spss. accident keyword combination cannot remember because did not intend press changed encoding in spss , text in data in different language english shown small boxes. nevertheless, when kind of analysis performed different language text shown in output. does know reason? tried change encoding did not produce result. first, @ edit > options , see whether setting unicode or locale. might fix it. if have text in multiple languages, want unicode. otherwise, may have specific locale set wrong. can change set locale, need know locale want use.
Read more

Add new record to the table by click on the button in Microsoft Access -

in ms access form want implement separate button, adds new record table. in order added button , attached button event: private sub btnaddrec_click() refresh codecontextobject on error resume next docmd.gotorecord , , acnewrec if err.number <> 0 btnaddrec.enabled = false end if end end sub everything ok when open window , click btnaddrec button, problem when first of perform navigation through existed records , after click on button. got runtime error: 2105: «you can't go specified record. may @ end of recordset» . how solve issue, need have ability add new record on click on specific button, no matter, have walked or not walked through records before. thanks. i created simple form field call description (and autonumber) , created button code follows click event. filled number of records , navigated through them, clicked addnewrec button. form navigated new record without issues. able click addnewrec button directly after
Read more

CSS3 Transition to highlight new elements created in JQuery -

i want use css3 color transition apply highlight-fading color effect (yellow transparent) new elements appended markup using jquery. css #content div { background-color:transparent; -moz-transition:background-color 2s; -webkit-transition:background-color 2s; -o-transition:background-color 2s; transition:background-color 2s; } #content div.new { background-color:yellow; } html <div id="content"></div> <a id="add-element" href="#">add new element</a> js $('#add-element').click(function() { var newelement = $('<div class="new">new element</div>'); $('#content').append(newelement); newelement.removeclass('new'); }); when click link, new element created. class "new" (background color yellow) , it's appended html markup. should able remove "new" class trigger background color transition transparent (or whate
Read more