php - Refactoring 3 functions -


i refactoring simple twitter application wrote when noticed appeared 3 (3) major code smells in form of following 3 functions:

private function get_friend_list($username, $twitter)     {         $getfield = '?screen_name=' . $username;         $url = 'https://api.twitter.com/1.1/users/show.json';                    $requestmethod = 'get';              return $twitter->setgetfield($getfield)                 ->buildoauth($url, $requestmethod)                 ->performrequest();      }      private function get_user_timeline($username, $twitter)     {                $getfield = '?screen_name=' . $username;         $url = 'https://api.twitter.com/1.1/statuses/user_timeline.json';                    $requestmethod = 'get';                          return $twitter->setgetfield($getfield)                        ->buildoauth($url, $requestmethod)                        ->performrequest();     }      private function get_favorites_list($username, $twitter)     {                $getfield = '?screen_name=' . $username;         $url = 'https://api.twitter.com/1.1/favorites/list.json';                $requestmethod = 'get';              return $twitter->setgetfield($getfield)                        ->buildoauth($url, $requestmethod)                        ->performrequest();           }

the 3 functions each return different information twitter user. however, break dry rule (don't repeat yourself) because each function identical except url fetch specific info twitter api.

questions:

  1. from refactoring standpoint, there wrong code?
  2. should combine 3 functions 1 (1) function?

i refactor this: 

private function get_favorites_list($username, $twitter, $path)     {                  $path = sanitize($path);         $getfield = '?screen_name=' . $username;         $url = 'https://api.twitter.com/1.1/' . $path;                $requestmethod = 'get';              return $twitter->setgetfield($getfield)                        ->buildoauth($url, $requestmethod)                        ->performrequest();           }

i recommend sanitizing $path not allow vulnerabilities creep in.


Comments

Post a Comment

Popular posts from this blog

.htaccess - First slash is removed after domain when entering a webpage in the browser -

sometimes when hit address of webpage in browser, removes first slash after domain. examples: www.mywebsite.com/scripts/script_6.php -> trying load www.mywebsite.comscripts/script_6.php www.mywebsite.com/test.php -> trying load www.mywebsite.comtest.php after entering again, loads page. a .htaccess settings must wrong: rewritebase / errordocument 404 http://www.mywebsite.com/oops.php errordocument 401 /notallowed.php rewriteengine on # turn on rewriting engine #gzip <ifmodule mod_deflate.c> addoutputfilterbytype deflate text/text text/html text/plain text/xml text/css application/x- javascript application/javascript </ifmodule> #end gzip rewritecond %{http_host} ^mywebsite\.com rewriterule ^(.*)$ http://www.mywebsite.com$1 [r=permanent,l] directoryindex index6.php rewriterule ^termsofuse/?$ termsofuse.php [nc,l] # handle requests "adpolicy" rewriterule ^privacy-policy/?$ privacy-policy.php [nc,l] # handle requ...
Read more

Automatically create pages in phpfox -

i have array of information of places , wanna use them create multiple pages in phpfox site. first tried manually insert data in phpfox database (in tables of phpfox_pages , phpfox_pages_text ). the page shown in site when opening it's link, site says: the page looking cannot found. do know other tables should manipulate make work? or know plugin phpfox same? thanks, solved ( @purefan guide): "pages" has user if take @ phpfox_user table, you'll found out how fetch new records on that. there 2 ambiguous fields in table ( password & password_salt ). can use script create values fields: <?php function generaterandomstring() { $length = 164; $characters = '-_0123456789abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'; $randomstring = ''; ($i = 0; $i < $length; $i++) { $randomstring .= $characters[rand(0, strlen($characters) - 1)]; } return $randomstring; } $ssalt = '';...
Read more

c# - Farseer ContactListener is not working -

i'm using farseer in xna project, have trouble contactlistener. created class contactlistener these 2 error messages , don't know how fix problems. the type or namespace name 'contactlistener' not found (are missing using directive or assembly reference?) the type or namespace name 'contactimpulse' not found (are missing using directive or assembly reference?) what wrong contactlistener class? class mycontactlistener: contactlistener { void begincontact(contact contact) { /* handle begin event */ } void endcontact(contact contact) { /* handle end event */ } void presolve(contact contact, ref manifold oldmanifold) { fixture fixturea = contact.fixturea; fixture fixtureb = contact.fixtureb; if (fixtureb.collisioncategories == category.cat10) { contact.enabled = false; } } void postsolve(contact contact, ref contactimpulse impulse) { /* handle post-solve event */ } }...
Read more